set inset based padding to RNTester#46354
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62247910 |
Summary: Pull Request resolved: facebook#46354 **Issue:** With forced edge-to-edge on Android 15, RNTester title at top overlaps with the status bar and bottom tab bar overlaps with bottom nav bar **Solution:** Add margins based on inset values to the ReactRootView which is the contentView for RNTesterActivity which acts as global padding within RNTester Changelog: [Android][Changed] - Adding padding for RNTester on Android 15 forced edge-to-edge Differential Revision: D62247910
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62247910 |
alanleedev
force-pushed
the
export-D62247910
branch
from
604fb4b to
6573b84
Compare
Contributor
|
This pull request has been merged in f7479e6. |
Collaborator
|
This pull request was successfully merged by @alanleedev in f7479e6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue:
With forced edge-to-edge on Android 15, RNTester title at top overlaps with the status bar and bottom tab bar overlaps with bottom nav bar
Solution:
Add margins based on inset values to the ReactRootView which is the contentView for RNTesterActivity which acts as global padding within RNTester
Changelog:
[Android][Changed] - Adding padding for RNTester on Android 15 forced edge-to-edge
Differential Revision: D62247910